Revert tinygo reflect.SliceHeader specialization #2210
Conversation
|
Drafting while waiting for the TinyGo release, to update failed integration tests. |
|
We are in process of releasing v0.32 so this PR should be prepared, please. |
|
Thanks for the heads up. I think this is mostly ready, I just need to update CI to download the v0.32 binaries, and run tests. |
Signed-off-by: Nuno Cruces <ncruces@users.noreply.github.com>
Signed-off-by: Nuno Cruces <ncruces@users.noreply.github.com>
|
Linux binaries still missing from here, will try again. |
|
@deadprogram it seems TinyGo v0.32 lost the ability to build |
| @@ -84,6 +84,7 @@ jobs: | |||
|
|
|||
| - name: Build TinyGo examples | |||
| run: make build.examples.tinygo | |||
| if: matrix.go-version != '1.20' # fails with TinyGo v0.32.0 | |||
There was a problem hiding this comment.
Idk how we feel about skipping building tests with Go 1.20 + TinyGo v0.32.0, as that seems to be an unsupported combination.
There was a problem hiding this comment.
yeah looks like a bug in TinyGo that -target=wasi is now trying to use GOOS=wasip1, which is not existent in Go 1.20, for source resolution vs previously it didn't use wasip1 target internally (I remember it used arm target virtually). I think anyway this is harmless so I will go ahead and merge. cc @deadprogram my guess is that the latest TinyGo breaks wasi builds for all Go versions <= 1.20.
In light of tinygo-org/tinygo#4156, we need to revert #2161.
Also use
unsafe.Addwhere feasible, and remove TODOs to useunsafe.Slicewhere doing so would raise ago vetwarning about misuse ofunsafe.Pointer.